Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: Invoke coqdoc in a temporary directory #17

Merged
merged 1 commit into from
Dec 18, 2020
Merged

Conversation

cpitclaudel
Copy link
Owner

Coqdoc writes coqdoc.css unconditionally in its cwd, so invoke it
from a temporary directory.

Fixes GH-16.

@palmskog
Copy link
Collaborator

palmskog commented Dec 18, 2020

Coqdoc writes coqdoc.css unconditionally in its cwd, so invoke it
from a temporary directory.

More precisely, coqdoc writes coqdoc.css unconditionally to its designated output directory, which can be given explicitly by -d (so it's not always cwd, but cwd is the default).

I tried this PR locally, and it solves the problem for me, so 👍 here.

Coqdoc writes coqdoc.css unconditionally in its cwd, so invoke it
from a temporary directory.

Fixes GH-16.
@cpitclaudel
Copy link
Owner Author

I added "-d" just in case, thanks for pointing that out. The test seems to pass on my machine, so 🚀

@cpitclaudel cpitclaudel merged commit eef4382 into master Dec 18, 2020
@cpitclaudel cpitclaudel deleted the coqdoc-mkdtemp branch December 18, 2020 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Running with coqdoc frontend leaves coqdoc.css in current directory
2 participants